Adds ignore to _deprecated example method#41
Merged
marcglasberg merged 1 commit intomarcglasberg:masterfrom Sep 5, 2025
Merged
Adds ignore to _deprecated example method#41marcglasberg merged 1 commit intomarcglasberg:masterfrom
_deprecated example method#41marcglasberg merged 1 commit intomarcglasberg:masterfrom
Conversation
Contributor
Author
|
Thanks! |
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Sep 5, 2025
…287 (#470) This bumps `assorted_layout_widgets` to the latest version. The current version is around 10 months old and excludes some changes made to remove obsolete lints that are preventing landing a change to the analysis server to produce warnings for that. Specifically, we want the PR from @pq merged at marcglasberg/assorted_layout_widgets#37 that removes `prefer_equal_for_default_values` and mine merged at marcglasberg/assorted_layout_widgets#41 to fix the error we found at #469 to unblock my change at https://dart-review.googlesource.com/c/sdk/+/448063.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working towards making the
analysis_options.yamlfile warn when the deprecated/removed version of a certain lint is lower than the current constraints (see https://dart-review.googlesource.com/c/sdk/+/448063 and dart-lang/sdk#59869).Some work was done at #37 to make this change land, but unfortunately, the work towards this got stale. Recently, I've picked it up again, and to land it, we have to bump the version of this project to allow Flutter rolls to pass. But we are encountering an issue with the
_deprecatedmethod under the tests being declared and never used (see flutter/tests#469).The change in this PR only adds an ignore comment above its declaration (so it can still be declared there for the convenience of uncommenting the code above). We could also make it public, but I don't suppose this is a desired path.