fix: Improve back button responsiveness in climb view #380
+67
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The back button was slow/unresponsive because AntD Button wrapped in Next.js Link component doesn't properly propagate click events. Fixed by using onClick handler consistently for all cases, which calls either window.history.back() or router.push() depending on navigation history.
- Create reusable BackButton component that handles: - Smart navigation (history.back() if same-origin, fallback URL otherwise) - Prefetching for fallback URLs - Icon-only display (no text) for consistent UI - Update climb-view-actions, settings, and auth pages to use BackButton - Remove unused BackToClimbList component (dead code)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The back button was slow/unresponsive because AntD Button wrapped in
Next.js Link component doesn't properly propagate click events. Fixed
by using onClick handler consistently for all cases, which calls either
window.history.back() or router.push() depending on navigation history.