perf: Batch favorites API calls in climb list #382
Merged
+108
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace individual useFavorite() hook per ClimbCard with single useFavoritesBatch() call at list level, reducing N API requests to 1 - Add optimistic update state management for immediate UI feedback - Remove useFavorite hook from ClimbCardActions, pass isFavorited as prop - Add React.memo wrapper to ClimbCardActions for better memoization - Update ClimbCard props and memo equality to include favorites state This significantly improves initial render performance by eliminating the waterfall of individual SWR requests for each visible climb card.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
React.memo wraps components, but ClimbCardActions is called as a function to produce an actions array for Ant Design Card. The memo wrapper caused the function to return a ReactElement instead of the expected array.
marcodejongh
added a commit
that referenced
this pull request
Dec 26, 2025
This reverts commit 8ed6f50.
marcodejongh
added a commit
that referenced
this pull request
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useFavoritesBatch() call at list level, reducing N API requests to 1
This significantly improves initial render performance by eliminating
the waterfall of individual SWR requests for each visible climb card.