Abc bank python carsonchan 0.0.1#12
Open
carsonsterlingchan wants to merge 9 commits intomarcus-burton:masterfrom
Open
Abc bank python carsonchan 0.0.1#12carsonsterlingchan wants to merge 9 commits intomarcus-burton:masterfrom
carsonsterlingchan wants to merge 9 commits intomarcus-burton:masterfrom
Conversation
added 9 commits
August 21, 2016 23:42
There are two sets of interest calculation tests: Simple Daily Interest and Compound Daily Interest. The Compound Daily Interest set is turned off. Please turn it on if that is the calculation you are looking for. Make sure interestFunc is set to self._cal_Compound_AccruedInt in interestEarned method in Account class file.
Modified to support new daily accrued interest calculations. Currently, interestEarned is set to use simple daily accrued interest method. Compound daily accrued interest calculation is included. This can be switched to use compound interest calculation. Set interestFunc = self._cal_Simple_AccruedInt
transDate. transDate is for interest calculation purpose. If transDate is not passed, it will be defaulted to current UTC datetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please kindly review the changes that I made primarily for the additional features. Currently, a simple daily accrued interest calculation is used for account interestEarned. A compound daily accrued interest calculation is also available in account.py file. Please let me know if you prefer the compound interest calculation. I will make the necessary change.