Skip to content

fix: register custom tasks in task list/show/run commands #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orban wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

fix: register custom tasks in task list/show/run commands #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions cmd/nightshift/commands/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,25 @@ import (
"text/tabwriter"
"time"

"github.com/marcus/nightshift/internal/config"
"github.com/marcus/nightshift/internal/logging"
"github.com/marcus/nightshift/internal/orchestrator"
"github.com/marcus/nightshift/internal/security"
"github.com/marcus/nightshift/internal/tasks"
"github.com/spf13/cobra"
)

// registerCustomTasks loads config and registers any user-defined custom tasks
// so they appear in task list/show/run. Mirrors the registration in run.go.
func registerCustomTasks() {
cfg, err := config.Load()
if err != nil {
return
}
tasks.ClearCustom()
_ = tasks.RegisterCustomTasksFromConfig(cfg.Tasks.Custom)
}

var taskCmd = &cobra.Command{
Use: "task",
Short: "Manage and run tasks",
Expand Down Expand Up @@ -80,6 +92,8 @@ func init() {
}

func runTaskList(cmd *cobra.Command, args []string) error {
registerCustomTasks()

categoryFilter, _ := cmd.Flags().GetString("category")
costFilter, _ := cmd.Flags().GetString("cost")
asJSON, _ := cmd.Flags().GetBool("json")
Expand Down Expand Up @@ -134,6 +148,8 @@ func runTaskList(cmd *cobra.Command, args []string) error {
}

func runTaskShow(cmd *cobra.Command, args []string) error {
registerCustomTasks()

taskType := tasks.TaskType(args[0])
promptOnly, _ := cmd.Flags().GetBool("prompt-only")
asJSON, _ := cmd.Flags().GetBool("json")
Expand Down Expand Up @@ -177,6 +193,8 @@ func runTaskShow(cmd *cobra.Command, args []string) error {
}

func runTaskRun(cmd *cobra.Command, args []string) error {
registerCustomTasks()

taskType := tasks.TaskType(args[0])
provider, _ := cmd.Flags().GetString("provider")
projectPath, _ := cmd.Flags().GetString("project")
Expand Down