Skip to content

Fix current errcheck lint failures #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix current errcheck lint failures #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 37 additions & 37 deletions cmd/cascade_cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ func TestCascadeCLIBasic(t *testing.T) {
defer database.Close()

epic := &models.Issue{Title: "Epic: Feature X", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

child := &models.Issue{Title: "Task: Implement", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child)
mustCreateIssue(t, database, child)

sessionID := "ses_test_cascade"

// Close child
child.Status = models.StatusClosed
now := time.Now()
child.ClosedAt = &now
database.UpdateIssue(child)
mustUpdateIssue(t, database, child)

cascaded, cascadedIDs := database.CascadeUpParentStatus(child.ID, models.StatusClosed, sessionID)

Expand All @@ -55,22 +55,22 @@ func TestCascadeCLIMultipleChildren(t *testing.T) {

sessionID := "ses_multi_children"
epic := &models.Issue{Title: "Epic: Big Feature", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

children := make([]*models.Issue, 3)
for i := 0; i < 3; i++ {
children[i] = &models.Issue{
Title: fmt.Sprintf("Child %d", i+1), Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID,
}
database.CreateIssue(children[i])
mustCreateIssue(t, database, children[i])
}

// Close first two
now := time.Now()
for i := 0; i < 2; i++ {
children[i].Status = models.StatusClosed
children[i].ClosedAt = &now
database.UpdateIssue(children[i])
mustUpdateIssue(t, database, children[i])
}

// Should NOT cascade yet
Expand All @@ -82,7 +82,7 @@ func TestCascadeCLIMultipleChildren(t *testing.T) {
// Close last child
children[2].Status = models.StatusClosed
children[2].ClosedAt = &now
database.UpdateIssue(children[2])
mustUpdateIssue(t, database, children[2])

// Now cascade
cascaded, _ = database.CascadeUpParentStatus(children[2].ID, models.StatusClosed, sessionID)
Expand All @@ -105,18 +105,18 @@ func TestCascadeCLINestedHierarchy(t *testing.T) {
sessionID := "ses_nested"

grandparent := &models.Issue{Title: "Epic: L1", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(grandparent)
mustCreateIssue(t, database, grandparent)

parent := &models.Issue{Title: "Epic: L2", Type: models.TypeEpic, Status: models.StatusOpen, ParentID: grandparent.ID}
database.CreateIssue(parent)
mustCreateIssue(t, database, parent)

child := &models.Issue{Title: "Task: L3", Type: models.TypeTask, Status: models.StatusOpen, ParentID: parent.ID}
database.CreateIssue(child)
mustCreateIssue(t, database, child)

now := time.Now()
child.Status = models.StatusClosed
child.ClosedAt = &now
database.UpdateIssue(child)
mustUpdateIssue(t, database, child)

cascaded, _ := database.CascadeUpParentStatus(child.ID, models.StatusClosed, sessionID)

Expand All @@ -143,13 +143,13 @@ func TestCascadeCLIStatusRules(t *testing.T) {

sessionID := "ses_rules"
epic := &models.Issue{Title: "Epic for review", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

child := &models.Issue{Title: "Child for review", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child)
mustCreateIssue(t, database, child)

child.Status = models.StatusInReview
database.UpdateIssue(child)
mustUpdateIssue(t, database, child)

cascaded, _ := database.CascadeUpParentStatus(child.ID, models.StatusInReview, sessionID)

Expand All @@ -170,12 +170,12 @@ func TestCascadeCLINoParent(t *testing.T) {
defer database.Close()

task := &models.Issue{Title: "Orphan Task", Type: models.TypeTask, Status: models.StatusOpen}
database.CreateIssue(task)
mustCreateIssue(t, database, task)

now := time.Now()
task.Status = models.StatusClosed
task.ClosedAt = &now
database.UpdateIssue(task)
mustUpdateIssue(t, database, task)

cascaded, cascadedIDs := database.CascadeUpParentStatus(task.ID, models.StatusClosed, "ses_orphan")

Expand All @@ -195,15 +195,15 @@ func TestCascadeCLIUndoable(t *testing.T) {

sessionID := "ses_undo_test"
epic := &models.Issue{Title: "Epic for undo", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

child := &models.Issue{Title: "Child for undo", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child)
mustCreateIssue(t, database, child)

now := time.Now()
child.Status = models.StatusClosed
child.ClosedAt = &now
database.UpdateIssue(child)
mustUpdateIssue(t, database, child)

database.CascadeUpParentStatus(child.ID, models.StatusClosed, sessionID)

Expand Down Expand Up @@ -231,15 +231,15 @@ func TestCascadeCLINonEpicParent(t *testing.T) {
defer database.Close()

parentTask := &models.Issue{Title: "Parent Task", Type: models.TypeTask, Status: models.StatusOpen}
database.CreateIssue(parentTask)
mustCreateIssue(t, database, parentTask)

childTask := &models.Issue{Title: "Child Task", Type: models.TypeTask, Status: models.StatusOpen, ParentID: parentTask.ID}
database.CreateIssue(childTask)
mustCreateIssue(t, database, childTask)

now := time.Now()
childTask.Status = models.StatusClosed
childTask.ClosedAt = &now
database.UpdateIssue(childTask)
mustUpdateIssue(t, database, childTask)

cascaded, _ := database.CascadeUpParentStatus(childTask.ID, models.StatusClosed, "ses_non_epic")

Expand Down Expand Up @@ -279,14 +279,14 @@ func TestCascadeCLITableDriven(t *testing.T) {

sessionID := fmt.Sprintf("ses_%s", tt.name)
parent := &models.Issue{Title: fmt.Sprintf("Parent: %s", tt.name), Type: tt.parentType, Status: models.StatusOpen}
database.CreateIssue(parent)
mustCreateIssue(t, database, parent)

children := make([]*models.Issue, tt.numChildren)
for i := 0; i < tt.numChildren; i++ {
children[i] = &models.Issue{
Title: fmt.Sprintf("Child %d", i+1), Type: models.TypeTask, Status: models.StatusOpen, ParentID: parent.ID,
}
database.CreateIssue(children[i])
mustCreateIssue(t, database, children[i])
}

now := time.Now()
Expand All @@ -295,7 +295,7 @@ func TestCascadeCLITableDriven(t *testing.T) {
if tt.targetStatus == models.StatusClosed {
children[i].ClosedAt = &now
}
database.UpdateIssue(children[i])
mustUpdateIssue(t, database, children[i])
}

cascaded, _ := database.CascadeUpParentStatus(children[tt.childrenToClose-1].ID, tt.targetStatus, sessionID)
Expand All @@ -322,21 +322,21 @@ func TestCascadeCLIInReviewStatus(t *testing.T) {
defer database.Close()

epic := &models.Issue{Title: "Epic in review", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

child1 := &models.Issue{Title: "Child 1", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child1)
mustCreateIssue(t, database, child1)

child2 := &models.Issue{Title: "Child 2", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child2)
mustCreateIssue(t, database, child2)

child1.Status = models.StatusInReview
database.UpdateIssue(child1)
mustUpdateIssue(t, database, child1)

now := time.Now()
child2.Status = models.StatusClosed
child2.ClosedAt = &now
database.UpdateIssue(child2)
mustUpdateIssue(t, database, child2)

cascaded, _ := database.CascadeUpParentStatus(child1.ID, models.StatusInReview, "ses_review")

Expand All @@ -357,18 +357,18 @@ func TestCascadeCLIMixedStatusChildren(t *testing.T) {
defer database.Close()

epic := &models.Issue{Title: "Mixed epic", Type: models.TypeEpic, Status: models.StatusOpen}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

child1 := &models.Issue{Title: "Open", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child1)
mustCreateIssue(t, database, child1)

child2 := &models.Issue{Title: "InProgress", Type: models.TypeTask, Status: models.StatusInProgress, ParentID: epic.ID}
database.CreateIssue(child2)
mustCreateIssue(t, database, child2)

child3 := &models.Issue{Title: "Closed", Type: models.TypeTask, Status: models.StatusClosed, ParentID: epic.ID}
now := time.Now()
child3.ClosedAt = &now
database.CreateIssue(child3)
mustCreateIssue(t, database, child3)

cascaded, _ := database.CascadeUpParentStatus(child3.ID, models.StatusClosed, "ses_mixed")

Expand All @@ -390,14 +390,14 @@ func TestCascadeCLIAlreadyClosed(t *testing.T) {

now := time.Now()
epic := &models.Issue{Title: "Closed epic", Type: models.TypeEpic, Status: models.StatusClosed, ClosedAt: &now}
database.CreateIssue(epic)
mustCreateIssue(t, database, epic)

child := &models.Issue{Title: "Orphan child", Type: models.TypeTask, Status: models.StatusOpen, ParentID: epic.ID}
database.CreateIssue(child)
mustCreateIssue(t, database, child)

child.Status = models.StatusClosed
child.ClosedAt = &now
database.UpdateIssue(child)
mustUpdateIssue(t, database, child)

cascaded, _ := database.CascadeUpParentStatus(child.ID, models.StatusClosed, "ses_already_closed")

Expand Down
Loading