refactor(recent-food): Encapsulate infrastructure — export only factories#1458
Merged
marcuscastelo merged 2 commits intomarcuscastelo/issue1447-remove-shimsfrom Dec 6, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…Repository Co-authored-by: marcuscastelo <27441558+marcuscastelo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Encapsulate infra exports in recent-food module
refactor(recent-food): Encapsulate infrastructure — export only factories
Dec 6, 2025
3376451
into
marcuscastelo/issue1447-remove-shims
10 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the recent-food infrastructure layer to enforce proper encapsulation by removing export keywords from internal helper functions in recentFoodRepository.ts. The five helper functions (fetchByUserTypeAndReferenceId, fetchUserRecentFoodsAsTemplates, insert, update, deleteByReference) are now file-local and accessible only through the createRecentFoodRepository() factory, which returns an object implementing the RecentFoodRepository interface.
Key changes:
- Removed
exportfrom 5 helper functions inrecentFoodRepository.ts, making them file-local - Maintained factory pattern where
createRecentFoodRepository()is the only public export - No breaking changes—application layer already uses the factory correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infrastructure files in
recent-foodwere exporting internal helper functions alongside their factories, violating encapsulation.Changes
recentFoodRepository.tsexportfrom 5 helper functions:fetchByUserTypeAndReferenceId,fetchUserRecentFoodsAsTemplates,insert,update,deleteByReferencecreateRecentFoodRepository()factoryOther files (
supabaseRecentFoodGateway.ts,supabaseRecentFoodMapper.ts,recentFoodCacheStore.ts,realtime.ts)Before/After
Application layer already uses factories correctly — no call-site changes needed.
Part of #1403
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.