Code restructure and parameterize secrets#3
Open
cybermoloch wants to merge 1 commit intomardahl:masterfrom
Open
Code restructure and parameterize secrets#3cybermoloch wants to merge 1 commit intomardahl:masterfrom
cybermoloch wants to merge 1 commit intomardahl:masterfrom
Conversation
Author
|
Oh, I used VSCode's "Format Document" function which did a lot of formatting changes. Sorry if that makes it harder to review in a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed the code around primarily to be able to pass the TenantID, ClientID, and ClientSecret as parameters. I've also made it easier to convert into a module later by making the main execution a function. (Although running it as a single script as its uses if pushing out through GPO for example.)
I would like to do some additional cleanup in regards to adding typing to more variables etc but wanted to know your interest in taking PRs.