Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a further iteration on the last PR in which I've added a way to run the script from the SYSTEM context and will rerun the command as the logged in user. This makes it easier to protect the client secret as they can be pulled from a protected registry key or similar with reduced read permissions. (I'll be making a third version for this which will pull from the registry but I don't think it would make sense as a PR since it will be specific to the software [Datto RMM and PolicyPak] I am deploying it with.)
I've submitted this as a separate PR as I am not sure this is a desired function in your use case.