Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use of the newly introduced
NullTypein Nitro. Replaces all occurences of the custom singeltonSQLiteNullValuetype withmargelo::nitro::NullTypeNote
Medium Risk
Updates the native/JSI boundary and public TS types around nulls and query results, which can affect runtime behavior and downstream type expectations. Core DB execution paths are touched but changes are largely mechanical/spec-driven.
Overview
Switches NitroSQLite null handling to Nitro’s built-in
NullType, removing the customSQLiteNullValue/NITRO_SQLITE_NULLplumbing and makingnulla first-classSQLiteValueacross TS and C++.Regenerates/renames Nitrogen specs and C++ hybrids (e.g.
HybridNitroSQLiteQueryResultSpec), updatesexecute/executeBatchsignatures to use the new types, and adds a nativerowsgetter (NitroSQLiteQueryResultRows) for TypeORM-style access.Updates the example app to accept the new null behavior (tests use
nulldirectly and drop simple-null-handling coverage), tweaks the unit test UI to useFlatList, and relaxesreact-native-nitro-modulesto*in the example lock/package.Written by Cursor Bugbot for commit cab8330. This will update automatically on new commits. Configure here.