URGENT - Update IodefElement.php #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
array_key_exists on objects is depricated and removed in php 7.4. Therefor i need to change this into an array, this quick hack makes it 7.4 compatible!
Owner
|
Thanks for the heads-up, I'm wondering why I didn't just use property_exists in there. Can you test with that? if (property_exists($this, 'value')) { |
Author
|
because it ws the best fix that i could think of. I am working on other packages that are more urgent to test atm (for speed i am currently using abuseio/iodef so i could continue coding) i dont know how both handle nesting though |
Owner
|
I'm using the same property_exists in code above, can't see this shouldn't work. Can you make a new PR with it so i can merge that one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array_key_exists on objects is depricated and removed in php 7.4. Therefor i need to change this into an array, this quick hack makes it 7.4 compatible!