test: use tree-sitter test fixtures#3
Conversation
|
Wait, I see I have duplicates and missed some ranges. Let me recount and ensure each range appears exactly once. I realize I still have duplicates and missing ranges. Let me count all ranges carefully and produce the final clean output. WalkthroughThe PR removes the Mocha-based test infrastructure (five files: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
test/corpus/concise_comment_fixtures.txt (1)
1-64:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winStandardize fixture naming pattern in concise_comment_fixtures.txt and concise_script_fixtures.txt to match peer files.
Both files deviate from the consistent "Fixture (htmljs target)" header format used throughout the rest of the corpus suite. The inconsistency affects maintainability and clarity.
test/corpus/concise_comment_fixtures.txt#L1-L64: Replace all three fixture headers with the standard "Fixture (htmljs target)" format (lines 2, 22, and 43 headers).test/corpus/concise_script_fixtures.txt#L1-L62: Replace both fixture headers with the standard format (lines 2 and 34 headers).For example:
- Line 2 should read:
Fixture concise-line-comment-before-fence-text (htmljs target)- Line 22 should read:
Fixture concise-block-comment-trailing-text-invalid (htmljs target)- Line 43 should read:
Fixture concise-block-comment-before-fence-text (htmljs target)And in concise_script_fixtures.txt:
- Line 2 should read:
Fixture script-concise-fenced-body-and-line-continuation (htmljs target)- Line 34 should read:
Fixture script-concise-forms-and-script-src-attr (htmljs target)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/corpus/concise_comment_fixtures.txt` around lines 1 - 64, Standardize the fixture header naming pattern across both test corpus files to match the consistent "Fixture <descriptive-name> (htmljs target)" format used in peer files. In test/corpus/concise_comment_fixtures.txt (lines 1-64), replace the three fixture headers at lines 2, 22, and 43 with "Fixture concise-line-comment-before-fence-text (htmljs target)", "Fixture concise-block-comment-trailing-text-invalid (htmljs target)", and "Fixture concise-block-comment-before-fence-text (htmljs target)" respectively. In test/corpus/concise_script_fixtures.txt (lines 1-62), replace the two fixture headers at lines 2 and 34 with "Fixture script-concise-fenced-body-and-line-continuation (htmljs target)" and "Fixture script-concise-forms-and-script-src-attr (htmljs target)" respectively.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@test/corpus/concise_comment_fixtures.txt`:
- Around line 1-64: Standardize the fixture header naming pattern across both
test corpus files to match the consistent "Fixture <descriptive-name> (htmljs
target)" format used in peer files. In test/corpus/concise_comment_fixtures.txt
(lines 1-64), replace the three fixture headers at lines 2, 22, and 43 with
"Fixture concise-line-comment-before-fence-text (htmljs target)", "Fixture
concise-block-comment-trailing-text-invalid (htmljs target)", and "Fixture
concise-block-comment-before-fence-text (htmljs target)" respectively. In
test/corpus/concise_script_fixtures.txt (lines 1-62), replace the two fixture
headers at lines 2 and 34 with "Fixture
script-concise-fenced-body-and-line-continuation (htmljs target)" and "Fixture
script-concise-forms-and-script-src-attr (htmljs target)" respectively.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0d7cc8c4-5075-4148-a229-0e497eea9695
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.jsonand included by**
📒 Files selected for processing (83)
__tests__/fixtures.test.mts__tests__/util/compare.mts__tests__/util/events.mts__tests__/util/htmljs.mts__tests__/util/tree-events.mtspackage.jsontest/corpus/argument_tag_fixtures.txttest/corpus/attr_fixtures.txttest/corpus/attribute_error_fixtures.txttest/corpus/attribute_expressions.txttest/corpus/attribute_group_fixtures.txttest/corpus/attribute_methods.txttest/corpus/attribute_spread_fixtures.txttest/corpus/attribute_value_fixtures.txttest/corpus/backtick_fixtures.txttest/corpus/bad_fixtures.txttest/corpus/cdata_and_doctype_fixtures.txttest/corpus/coma_fixtures.txttest/corpus/comma_attribute_fixtures.txttest/corpus/comma_fixtures.txttest/corpus/commas_fixtures.txttest/corpus/comments_and_edges.txttest/corpus/comments_fixtures.txttest/corpus/complex_fixtures.txttest/corpus/concise_comment_fixtures.txttest/corpus/concise_fixtures.txttest/corpus/concise_mode.txttest/corpus/concise_script_fixtures.txttest/corpus/core_syntax_regressions.txttest/corpus/css_fixtures.txttest/corpus/default_fixtures.txttest/corpus/double_hyphen_fixtures.txttest/corpus/dtd_fixtures.txttest/corpus/empty_fixtures.txttest/corpus/eof_fixtures.txttest/corpus/eof_open_tag_fixtures.txttest/corpus/html_fixtures.txttest/corpus/html_mode.txttest/corpus/ignoreNonstandardStringPlaceholders_fixtures.txttest/corpus/ignorePlaceholders_fixtures.txttest/corpus/invalid_fixtures.txttest/corpus/marko6_forms.txttest/corpus/marko_tags.txttest/corpus/mixed_fixtures.txttest/corpus/multi_fixtures.txttest/corpus/multiline_fixtures.txttest/corpus/multiple_fixtures.txttest/corpus/nested_fixtures.txttest/corpus/open_fixtures.txttest/corpus/open_tag_comment_fixtures.txttest/corpus/param_fixtures.txttest/corpus/parsed_fixtures.txttest/corpus/pending_regressions.txttest/corpus/placeholder_edge_fixtures.txttest/corpus/placeholder_eof_fixtures.txttest/corpus/placeholder_fixtures.txttest/corpus/raw_text_edge_fixtures.txttest/corpus/root_fixtures.txttest/corpus/script_fixtures.txttest/corpus/scriptlet_fixtures.txttest/corpus/self_fixtures.txttest/corpus/semicolon_fixtures.txttest/corpus/shorthand_fixtures.txttest/corpus/shorthand_id_class_fixtures.txttest/corpus/simple_fixtures.txttest/corpus/single_fixtures.txttest/corpus/statement_fixtures.txttest/corpus/stray_fixtures.txttest/corpus/strip_fixtures.txttest/corpus/tag_default_value_fixtures.txttest/corpus/tag_fixtures.txttest/corpus/text_fixtures.txttest/corpus/textarea_fixtures.txttest/corpus/top_level.txttest/corpus/ts_fixtures.txttest/corpus/unary_fixtures.txttest/corpus/unclosed_fixtures.txttest/corpus/var_fixtures.txttest/corpus/void_fixtures.txttest/corpus/void_tag_fixtures.txttest/corpus/whitespace_fixtures.txttest/corpus/xml_declaration_fixtures.txttest/corpus/xml_fixtures.txt
💤 Files with no reviewable changes (5)
- tests/util/compare.mts
- tests/util/events.mts
- tests/fixtures.test.mts
- tests/util/htmljs.mts
- tests/util/tree-events.mts
No description provided.