Skip to content

chore: update lazy load docs#141

Merged
DylanPiercey merged 1 commit into
mainfrom
lazy-load-docs-cleanup
Jun 14, 2026
Merged

chore: update lazy load docs#141
DylanPiercey merged 1 commit into
mainfrom
lazy-load-docs-cleanup

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

No description provided.

@DylanPiercey DylanPiercey merged commit c26ed5a into main Jun 14, 2026
2 checks passed
@DylanPiercey DylanPiercey deleted the lazy-load-docs-cleanup branch June 14, 2026 03:20
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43e3ce9e-fceb-460b-ba89-bceb32ca6d3b

📥 Commits

Reviewing files that changed from the base of the PR and between c333418 and f7f20a3.

📒 Files selected for processing (1)
  • docs/reference/lazy-loading.md

Walkthrough

The docs/reference/lazy-loading.md page is updated to clarify that the load attribute value is resolved at build time and must be a static string, and that triggers control only when the tag's bundle is fetched, not whether the tag renders. Selector guidance is expanded to cover IDs, classes, and attribute selectors, with a note about spacing after bare type selectors. The visible trigger and rootMargin examples are revised to use the new selector format. A tip is added about using facades to centralize media trigger configuration. The Events subsection examples are updated to match the revised selector syntax. A new "Facade Tags" section is introduced, demonstrating always-lazy behavior via a facade wrapper with a nested tags/ directory. The "Placeholders & Errors" example is replaced with a chart figure using <try>, @placeholder, and @catch.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lazy-load-docs-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant