Skip to content

⚡ Optimize GetComponent to TryGetComponent in GPUInstancerPrefabManager#511

Open
marko1olo wants to merge 1 commit into
mainfrom
perf/optimize-getcomponent-prefabmanager-3244040335269934407
Open

⚡ Optimize GetComponent to TryGetComponent in GPUInstancerPrefabManager#511
marko1olo wants to merge 1 commit into
mainfrom
perf/optimize-getcomponent-prefabmanager-3244040335269934407

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

💡 What:
Replaced multiple GetComponent calls inside the SetRenderersEnabled method with TryGetComponent to fetch LODGroup and Rigidbody components.

🎯 Why:
The GetComponent method creates unnecessary garbage collection allocations and C++/C# boundary overhead when a component does not exist. Since TryGetComponent evaluates in C++ and safely returns false without allocating a C# stub, replacing these inside frequently called rendering blocks significantly optimizes instance processing paths.

📊 Measured Improvement:
Because the solution structure lacks local console runner testing compatibility and Unity tests are filtered out of the explicit CLI runner, standard .NET benchmarks could not directly measure the Unity boundary improvement programmatically in this environment. However, documentation indicates this reliably improves single-component checking overhead by avoiding allocating null wrapper objects, improving runtime CPU and GC times.


PR created automatically by Jules for task 3244040335269934407 started by @marko1olo

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant