🧪 Add missing error test for AmbientBiotaDirector try-catch#524
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Added
AmbientBiotaDirectorUploadTests.csto test the try-catch block insideAmbientBiotaDirector.UploadPackedGpuInstancesby purposely passing a disposed NativeArray.📊 Coverage:
The test verifies that an invalid operation inside
TryBuildGpuInstancewill bubble up gracefully through the finally block whereUnlockBufferAfterWriteensures the buffer lock is released correctly.✨ Result:
Improved test coverage on a highly critical fast-path function interacting with native buffers!
PR created automatically by Jules for task 3203229797070636321 started by @marko1olo