Skip to content

🧪 Add error test for try-finally in AmbientBiotaDirector#528

Merged
marko1olo merged 1 commit into
mainfrom
jules-17048931417167177332-c3afc3f2
Jun 27, 2026
Merged

🧪 Add error test for try-finally in AmbientBiotaDirector#528
marko1olo merged 1 commit into
mainfrom
jules-17048931417167177332-c3afc3f2

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

🎯 What: The AmbientBiotaDirector.CompleteActiveJobForTeardown method's DispatcherJobFence.TryComplete inside a try-finally block was missing an error/exception path test. We needed to ensure that if JobHandle.Complete fails (for instance if executed incorrectly off the main thread), the finally block properly triggers to release the _activeSwapWindowDepth.

📊 Coverage: A new edit-mode test AmbientBiotaDirectorTeardownErrorEditTests.cs uses Task.Run to deliberately execute JobHandle.Complete on a background thread. This effectively triggers an InvalidOperationException natively from Unity which allows us to assert that finally block successfully executed and properly managed DispatcherJobFence.EndPostSimulationSwapWindow and _jobPending resources.

Result: Better confidence when making refactorings touching AmbientBiotaDirector, job queues, or DispatcherJobFence swap window interactions as exception paths are actively monitored.


PR created automatically by Jules for task 17048931417167177332 started by @marko1olo

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@marko1olo marko1olo merged commit d605993 into main Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant