🧪 Add error test for try-finally in AmbientBiotaDirector#528
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The
AmbientBiotaDirector.CompleteActiveJobForTeardownmethod'sDispatcherJobFence.TryCompleteinside atry-finallyblock was missing an error/exception path test. We needed to ensure that ifJobHandle.Completefails (for instance if executed incorrectly off the main thread), thefinallyblock properly triggers to release the_activeSwapWindowDepth.📊 Coverage: A new edit-mode test
AmbientBiotaDirectorTeardownErrorEditTests.csusesTask.Runto deliberately executeJobHandle.Completeon a background thread. This effectively triggers anInvalidOperationExceptionnatively from Unity which allows us to assert thatfinallyblock successfully executed and properly managedDispatcherJobFence.EndPostSimulationSwapWindowand_jobPendingresources.✨ Result: Better confidence when making refactorings touching
AmbientBiotaDirector, job queues, orDispatcherJobFenceswap window interactions as exception paths are actively monitored.PR created automatically by Jules for task 17048931417167177332 started by @marko1olo