Skip to content

⚡ Optimize MapMagicBrush lookup in Undo event loops#532

Merged
marko1olo merged 1 commit into
mainfrom
jules-11687578998825631762-09f869c7
Jun 28, 2026
Merged

⚡ Optimize MapMagicBrush lookup in Undo event loops#532
marko1olo merged 1 commit into
mainfrom
jules-11687578998825631762-09f869c7

Conversation

@marko1olo

Copy link
Copy Markdown
Owner

💡 What: Implemented a static HashSet cache for MapMagicBrush instances. It is populated securely on the main thread via Awake() and OnDestroy(), ensuring no thread-safety issues during Unity domain reloads. The expensive FindObjectsByType search query in UndoBac.cs and UndoFull.cs has been replaced by simply iterating over this cached registry.

🎯 Why: Scene-wide object search (GameObject.FindObjectsByType) with FindObjectsInactive.Include is exceptionally slow. It causes a C++-to-C# transition, allocates garbage, and searches the entire scene hierarchy on every brush undo/redo event loop, causing major frame time drops.

📊 Measured Improvement: Replaces an O(N) operation (where N = number of GameObjects in the scene hierarchy) with an O(M) operation (where M = total active/instantiated brushes in the cache, usually <= 1) and completely skips hierarchical layout searches.


PR created automatically by Jules for task 11687578998825631762 started by @marko1olo

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@marko1olo marko1olo merged commit 2398125 into main Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant