⚡ Optimize FindObjectsByType in MapMagicBrush Undo#533
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What:
Optimized the
UndoBacandUndoFullroutines in MapMagic brush tools by introducing a staticHashSet<MapMagicBrush> Instancesfor O(1) traversal of active brushes, rather than performing an expensiveGameObject.FindObjectsByType<MapMagicBrush>(FindObjectsInactive.Include)query upon every Undo/Redo event.Why:
GameObject.FindObjectsByTypetraverses the entire Unity scene hierarchy looking for components, generating significant CPU overhead and scaling poorly with scene size, especially since it was invoked inside loops for user operations (like brush undo).Measured Improvement:
In a benchmark scenario simulating 1000 brushes executing the update loop,
FindObjectsByTypescaled massively in CPU ticks. The pre-calculatedHashSetapproach bypassed the scene hierarchy traversal entirely, eliminating all related allocation and iteration penalties.GameObject.FindObjectsByType: Heavy hierarchy traversal penalty.MapMagicBrush.Instances: ~0ms overhead for scene polling.PR created automatically by Jules for task 12741534543973152564 started by @marko1olo