feat(admin): load pedidos asynchronously by marpisco · Pull Request #190 · marpisco/ClassLink

marpisco · 2026-07-05T02:33:41Z

Motivation

Remove the initial page-load animation class that affects the pedidos list and provide a faster, non-blocking UX for administrators.
Provide focused API endpoints to fetch filtered/paginated reservation requests and to approve/reject requests programmatically while reusing the app's existing auth/session/CSRF patterns.
Keep the existing server-side behavior as a non-JavaScript fallback and preserve current email notification and logging behavior for approvals/rejections.

Description

Add admin/api/pedidos_list.php which returns authenticated, paginated, filtered reservation records (sala / requisitor) with prepared statements and the same session/auth guards used by other admin APIs.
Add admin/api/pedidos_action.php which accepts CSRF-protected POSTs to aprovar / rejeitar single or bulk reservations, performs DB updates/deletes, logs actions via logaction, and invokes the existing email helpers for notifications.
Update admin/pedidos.php to stop applying the fade-in class on initial load, add skeleton styling, wrap the server-rendered pedidos area in #pedidosResults and #pedidosAlerts, and inject client-side JS that intercepts filter submissions, shows skeleton rows while loading, fetches page 1 via AJAX from pedidos_list.php, appends more results on scroll via a page parameter, and submits approve/reject (single and bulk) via pedidos_action.php while falling back to the original form/URL when network/JS handling fails.
Preserve CSRF handling by reading the global-csrf-token hidden value and including it in programmatic requests, and reuse the existing sendReservationApprovedEmail, sendReservationRejectedEmail, sendBulkReservationApprovedEmail, and sendBulkReservationRejectedEmail helpers for notifications.

Testing

Ran PHP syntax checks: php -l admin/pedidos.php, php -l admin/api/pedidos_list.php, and php -l admin/api/pedidos_action.php, all reporting no syntax errors.
Ran git diff --check to verify whitespace/format issues and fixed trailing whitespace reported by the check.
Verified added files pass the same session/auth/CSRF guard patterns used by existing admin APIs by mirroring checks from admin/api/dashboard_stats.php and admin/api/users_search.php.

Codex Task

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-07-05T02:33:48Z

📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be69d0934c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Resolves the main merge conflict in the pedidos admin page while keeping the current admin shell layout and the async loading skeleton. Fixes the async pedidos review findings by moving rendered row actions off fragile inline handlers, preserving server-rendered action results, surfacing email warnings, refreshing stats, searching through the list API, keeping pagination deterministic, replacing stale filter loads, and preserving single-reservation email templates. Tested with git diff --check, git diff --cached --check, PHP lint on admin/pedidos.php and both pedidos API endpoints, and node --check on the extracted inline pedidos script. Co-authored-by: Codex <noreply@openai.com>

github-actions · 2026-07-05T03:24:58Z

📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco

marpisco · 2026-07-05T03:29:16Z

@codex
Minor detail,

Search box is also reloaded, so if I'm typing, it'll remove my focus from the searchbox,

Also, since it's being reloaded, if I type something that has no results, it'll make the searchbox disappear and force me to have to reload the entire page.

chatgpt-codex-connector · 2026-07-05T03:31:17Z

Summary

Kept the pedidos search controls visible whenever an active search returns zero results, so admins can edit the query instead of losing the search box. admin/pedidos.phpL1302-L1312 admin/pedidos.phpL1324-L1331
Preserved and restored search-box focus and caret position after async result rerenders. admin/pedidos.phpL1299-L1301 admin/pedidos.phpL1338-L1352
Avoided replacing the focused search input with skeleton loading rows during search-triggered reloads. admin/pedidos.phpL1364-L1369
Committed the change with commit 77e6423 and created a follow-up PR titled fix(admin): preserve pedidos search during async reloads.

Testing

✅ php -l admin/pedidos.php
✅ git diff --check

View task →

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-07-05T03:32:35Z

📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco

Moves the async pedidos empty-state container below the search and bulk controls so the controls stay first when a search has no results. This keeps the previous focus-preservation behavior while matching the expected layout. Tested with php -l admin/pedidos.php and git diff --check. Co-authored-by: Codex <noreply@openai.com>

github-actions · 2026-07-05T03:36:13Z

📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco

Moves the AJAX pedidos search field into a stable header, matching the simple form-control search used on the salas page. The async renderer now updates only the results area, so typing does not lose focus or trigger the blue focus flicker when new data arrives. Shows the existing loading spinner during focused search reloads instead of replacing the search input. The server-side fallback remains hidden from the async header when an action result is being shown. Tested with php -l admin/pedidos.php and git diff --check. Co-authored-by: Codex <noreply@openai.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-07-05T03:42:11Z

📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco

marpisco

LGTM

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10ae7e7faf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-05T03:52:53Z

+    echo json_encode(['error' => 'Acesso negado.']);
+    exit;
+}
+if (!isset($_SESSION['validity']) || $_SESSION['validity'] < time()) {


Extend sessions for async pedidos requests

When admins keep this page open and interact only through the new async list/action endpoints, these requests bypass admin/index.php, where near-expiry sessions are extended by another 30 minutes. This guard only rejects once validity is in the past, so an actively filtering/scrolling admin can still be logged out as soon as the original timestamp expires; mirror the sliding-session refresh in the API auth path as well.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-05T03:52:53Z

+    const hasServerAction = new URLSearchParams(window.location.search).has('subaction');
+    if (!hasServerAction) {
+        document.getElementById('pedidosAsyncHeader')?.classList.remove('d-none');
+        loadPedidos(true);


Skip full server render before async fetch

On /admin/pedidos.php without subaction, this async fetch starts only after the PHP default branch above has already queried and emitted every pending reservation, including the per-row sala/cache/tempo lookups. Installations with many pending requests now pay the full old render plus an extra API request before the browser replaces it, so the new pagination does not protect the initial load; gate the server-side table to a fallback/no-JS path or leave the container empty for the async path.

Useful? React with 👍 / 👎.

Copilot AI review requested due to automatic review settings July 5, 2026 02:33

marpisco added the codex label Jul 5, 2026 — with ChatGPT Codex Connector

Copilot AI reviewed Jul 5, 2026

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

marpisco force-pushed the codex/add-asynchronous-loading-for-pedidos-list branch from be69d09 to 05a122b Compare July 5, 2026 03:24

fix(admin): preserve pedidos search while reloading

c180c0c

Copilot AI review requested due to automatic review settings July 5, 2026 03:32

Copilot AI reviewed Jul 5, 2026

Copilot AI review requested due to automatic review settings July 5, 2026 03:42

Copilot AI reviewed Jul 5, 2026

marpisco commented Jul 5, 2026

View reviewed changes

marpisco merged commit f77772e into main Jul 5, 2026
6 checks passed

marpisco deleted the codex/add-asynchronous-loading-for-pedidos-list branch July 5, 2026 03:44

chatgpt-codex-connector Bot reviewed Jul 5, 2026

View reviewed changes

Conversation

marpisco commented Jul 5, 2026

Motivation

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

marpisco commented Jul 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 5, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 5, 2026

Uh oh!

marpisco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants