fix(admin): align pedidos title styling#195
Conversation
|
📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab7bb3e518
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| background: var(--gradient-primary); | ||
| -webkit-background-clip: text; | ||
| background-clip: text; | ||
| -webkit-text-fill-color: transparent; |
There was a problem hiding this comment.
Add a fallback gradient for the transparent title
On admin pages this stylesheet is emitted after require 'index.php', and admin/index.php only loads Bootstrap plus theme-switcher.js, not assets/theme.css, so --gradient-primary is not defined in this context. When this background declaration is invalid, the following -webkit-text-fill-color: transparent still applies in Chromium/Safari, making the “Gestão de Pedidos” heading invisible instead of merely restyled. Add a fallback value here or load the theme variables for admin pages before using them.
Useful? React with 👍 / 👎.
|
@codex Change this to fit the rest of the titles like the module, nevermind the original prompt that talked about the title colors (keep the prompt in mind as for fixing the GAP, that is still not fixed). Take the example of /admin/salas.php. Modify it to fit that font style (not centered, keep it justified to the left). Also, currently it's just black text on a black background (I'm working in dark mode), keep in consideration that this must work between both device themes. The gap is still there fyi. Not sure if it's a margin of some sort in some CSS sheet that's loaded. |
Summary
Testing
Committed changes on the current branch with commit |
|
📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco |
Aligns the pedidos page title with its description by replacing the nested inline span with a simple title class.\n\nUses the existing ClassLink primary gradient and removes extra title spacing so the header layout stays aligned without shifting the description or page content.\n\nTested with php -l admin/pedidos.php.\n\nCo-authored-by: Codex <noreply@openai.com>
b9f0367 to
55db9fb
Compare
|
📝 Manual Update Required? It looks like you've modified core logic. Please check if the user manual needs a refresh! @marpisco |
|
LGTM. |
Motivation
Description
admin/pedidos.phpfoi adicionada a classe CSS.classlink-page-titlecomline-height, margem reduzida ebackground: var(--gradient-primary)e o bloco anterior comspaninline foi substituído por<h2 class="classlink-page-title">Gestão de Pedidos</h2>para eliminar espaçamentos extras.Testing
php -l admin/pedidos.phppara verificação de sintaxe e não foram encontrados erros.Codex Task