Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates timeout parsing logic across multiple command files by introducing a singleton-based RootContext() function in cmd/root.go. This eliminates code duplication where each command previously implemented its own timeout parsing and context creation logic.
- Introduces a centralized
RootContext()function using the singleton pattern - Removes duplicated timeout parsing code from 16 command files
- Standardizes context creation across all commands
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/root.go | Adds centralized RootContext() function with singleton pattern for timeout parsing |
| cmd/transfer.go | Replaces local timeout parsing with RootContext() call |
| cmd/show.go | Replaces local timeout parsing with RootContext() call |
| cmd/revert.go | Replaces local timeout parsing with RootContext() call |
| cmd/rev-parse.go | Replaces local timeout parsing with RootContext() call |
| cmd/log.go | Replaces local timeout parsing with RootContext() call |
| cmd/init.go | Replaces local timeout parsing with RootContext() call |
| cmd/diff.go | Replaces local timeout parsing with RootContext() call |
| cmd/debit.go | Replaces local timeout parsing with RootContext() call |
| cmd/credit.go | Replaces local timeout parsing with RootContext() call |
| cmd/commit.go | Replaces local timeout parsing with RootContext() call |
| cmd/checkout.go | Replaces local timeout parsing with RootContext() call |
| cmd/bring-to.go | Replaces local timeout parsing with RootContext() call |
| cmd/branch.go | Replaces local timeout parsing with RootContext() call |
| cmd/balance.go | Replaces local timeout parsing with RootContext() call |
…ackground context. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the timeout parsing into a single place. It uses the singleton pattern, so multiple helpers can call it without concern.
Fixes #108