Improve error handling: stop silently swallowing errors#2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Improve error handling: stop silently swallowing errors#2devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several handlers in
calc.pyeither raneval()/float()with no error handling — so invalid or empty input raised exceptions that Tkinter's callback loop silently swallowed to stderr, leaving the UI unresponsive with no feedback — or caught errors without logging them. This PR makes those failures visible: the user sees"Error"and the exception is logged, instead of the app doing nothing or crashing.Changes:
square(),sqrt(),perc(): wrapped theeval()calls intry/except. On failure they nowlogger.exception(...)and setcurrent_expression = "Error"(matchingevaluate()'s behavior) instead of letting an uncaughtSyntaxError/NameErrorescape. Previously e.g. pressingx²with an empty display crashed the callback (eval("**2")→SyntaxError).evaluate(): theexcept Exception as e:swallowedewithout logging. Now logs vialogger.exception(...)and also clearstotal_expressionso a bad expression doesn't persist into the next evaluation.memoria()(MS/M+/M-):float(self.current_expression)on non-numeric input (e.g."Error") raised an uncaughtValueError. Now the value is parsed once up front; onValueErrorit logs a warning, shows"Error", and returns instead of crashing.__init__:tk.PhotoImage(file=...)raised an uncaughtTclErrorand aborted startup if the icon was missing. Now caught and logged as a warning so the app still launches.loggerandlogging.basicConfig(...)in__main__so these logs actually surface.Behavior verified headlessly (xvfb): empty
x²/√,M+on"Error", and evaluating an invalid expression all resolve to"Error"without crashing.Link to Devin session: https://app.devin.ai/sessions/af3f52009c97490cab8030809ab866ef
Requested by: @martlyma