Skip to content

Resolviendo el ejercicio creando un diccionario con lo valores mutabl…#3541

Open
pablomoriv9830 wants to merge 2 commits into
mate-academy:masterfrom
pablomoriv9830:master
Open

Resolviendo el ejercicio creando un diccionario con lo valores mutabl…#3541
pablomoriv9830 wants to merge 2 commits into
mate-academy:masterfrom
pablomoriv9830:master

Conversation

@pablomoriv9830
Copy link
Copy Markdown

…es e inmutables ordenados en orden alfabético

…es e inmutables ordenados en orden alfabético
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The implementation correctly classifies all 8 variables into mutable and immutable categories, meeting all functional requirements. The only issue detected is a minor style violation: W292 no newline at end of file in app/main.py. This is a cosmetic PEP 8 formatting issue that doesn't affect code functionality. Simply add a trailing newline at the end of the file to resolve it, which most text editors do automatically. Your core logic and variable classification are solid and complete.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants