t1#3748
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution has a critical blocker that prevents the component tests from running. The Person component in src/components/Person/Person.jsx is not properly exported, causing a SyntaxError when the test tries to import it: The requested module '/__cypress/src/src/components/Person/Person.jsx' does not provide an export named 'Person'. This must be fixed before the tests can pass. Add a named export to your component, for example: export const Person = (props) => { // component implementation }; Minor style improvements (can be addressed after fixing the export): - Format ternary operator operands on separate lines per [CHECKLIST ITEM #2] - Consider extracting the partner reference text to a variable for cleaner conditional rendering per [CHECKLIST ITEM #3] Once you add the proper export, the component tests should run successfully since the page tests are already passing.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution has one functional issue that must be fixed: the unmarried message outputs "not married" but the task requirement specifies "I am not married" — this text must match exactly. Additionally, there are two explicit checklist violations: [CHECKLIST ITEM #2] requires ternary operator operands to be formatted on separate lines (condition, true branch, and false branch each on their own line), and [CHECKLIST ITEM #3] requires extracting the nested sex === 'm' ? 'wife' : 'husband' expression into a separate partnerType variable rather than embedding it directly in the template literal. These checklist violations are blockers as explicitly noted in the criteria. The named export and overall implementation approach are correct — once you fix the text output and format the ternary operators according to the checklist, the task will be complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
qual o erro meu ousado? |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is an educational override to help you progress while learning. Your implementation shows good progress - you've successfully extracted the partnerRole as a separate variable (fixing CHECKLIST ITEM #3), and the destructuring is correct. However, two issues remain: (1) The unmarried message on line 37 outputs 'not married' but should be 'I am not married' to match the exact requirement. (2) The ternary operator formatting needs CHECKLIST ITEM #2 attention - each operand should be on its own line for better readability. These are straightforward fixes that will complete your solution. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| <p className="Person__partner"> | ||
| {isMarried | ||
| ? `${partnerName} is my ${partnerRole}` : 'not married'} |
There was a problem hiding this comment.
The unmarried message text must match exactly "I am not married" per the task requirements. Change 'not married' to 'I am not married'.
| <p className="Person__partner"> | ||
| {isMarried | ||
| ? `${partnerName} is my ${partnerRole}` : 'not married'} |
There was a problem hiding this comment.
Checklist Item #2 violation: Format ternary operator operands with each on its own line. Move the false branch ': 'I am not married'' to a new line after the true branch.
2 participants
No description provided.