Skip to content

Develop#962

Open
Evg3n22 wants to merge 32 commits intomate-academy:masterfrom
Evg3n22:develop
Open

Develop#962
Evg3n22 wants to merge 32 commits intomate-academy:masterfrom
Evg3n22:develop

Conversation

@Evg3n22
Copy link
Copy Markdown

@Evg3n22 Evg3n22 commented Apr 2, 2026

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to fix the tests and provide working DEMO LINK to the PR description

@Evg3n22 Evg3n22 requested a review from brespect April 4, 2026 17:02
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. image is too large, so scrolling appears
Image
  1. don't forget to increase these numbers as well
Image
  1. footer should not stretch
Image
  1. font looks different
Image
  1. add a title and favicon
Image
  1. after reloading a non-homepage, an error appears
Image

@Evg3n22
Copy link
Copy Markdown
Author

Evg3n22 commented Apr 5, 2026

If you find a problem in the cart page, delete cart from local storage

@Evg3n22 Evg3n22 requested a review from etojeDenys April 6, 2026 05:30
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link does not work. please fix it and request the review again

Image

@Evg3n22 Evg3n22 requested a review from etojeDenys April 6, 2026 15:54
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the demo has the same problem

if you get stuck, feel free to ask for help in the chat

@Evg3n22 Evg3n22 requested a review from etojeDenys April 7, 2026 05:59
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. Something went wron when I add to cart from product list and after that select that product and it should be already added, but I have the ability to add same product in Product Details Page one more time, so after that I got this screen:
Image
  1. When you select something in "You may also like" section, it should smoothly scrolls to the top.

  2. All Footer links should refer to existing resourses.

@Evg3n22 Evg3n22 requested a review from brespect April 7, 2026 07:44
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done, just last fixes:

  1. it would be better to open these links in a new tab
Image
  1. recheck all your fonts because they look different
Image Image

@Evg3n22 Evg3n22 requested a review from etojeDenys April 7, 2026 09:30
Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. White space appears on page where is the phone's info
Image
  1. I would recommend to remove default button's border width
Image
  1. Scroll should be disabled when menu is open
Image

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't open your solution due to error:
Image

@Evg3n22 Evg3n22 requested a review from brespect April 8, 2026 07:15
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like nothing changes from my previous review:
Image

@Evg3n22 Evg3n22 requested a review from brespect April 8, 2026 18:30
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants