Address review feedback - #24
Merged
Merged
Conversation
mate-h
commented
Jul 27, 2026
Comment on lines
+47
to
+52
| /// Bytes contributed by each world-cache cell in the packed SoA buffer, excluding the fixed-size | ||
| /// `b` array that sits between `a` and `active_cell_indices`. | ||
| /// | ||
| /// The `ShaderType` mirror lives in this module and is intentionally private so it cannot be | ||
| /// constructed, because it would be too large. | ||
| mod world_cache_layout { | ||
| use bevy_math::{Vec3, Vec4}; | ||
| use bevy_render::render_resource::ShaderType; | ||
| /// Keep in sync with `WorldCache` in `realtime_bindings.wgsl`: | ||
| /// `checksums` (4) + `life` (4) + `radiance` (16) + `geometry_data` (32) + `luminance_deltas` (4) | ||
| /// + `active_cells_new_radiance` (16; `vec3` array stride) + `a` (4) + `active_cell_indices` (4). |
Owner
Author
There was a problem hiding this comment.
These code comments are way too verbose, will simplify to just say it's the sum of the fields sizes.
Comment on lines
+55
to
+58
| /// Size of the fixed `b` array (`array<u32, WORLD_CACHE_SIZE / 1024>`) in the packed buffer. | ||
| const WORLD_CACHE_B_SIZE: u64 = (WORLD_CACHE_SIZE / 1024) * size_of::<u32>() as u64; | ||
|
|
||
| /// Offset of `active_cells_count` in the packed world cache buffer. |
Owner
Author
There was a problem hiding this comment.
No need to reiterate this indexes the packed buffer, self explanatory can simplify too.
mate-h
marked this pull request as ready for review
July 27, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address feedback