fix(fidohid): set uniq to ASCII string to prevent udev rule failure#33
Merged
Conversation
psanford/uhid fills the uniq field with 64 random bytes when unset.
Binary garbage in HID_UNIQ causes 90-brltty-hid.rules to abort the
entire udev transaction for the hidraw device, so fido_id never runs,
ID_SECURITY_TOKEN is never set, and uaccess is never granted — leaving
/dev/hidraw* inaccessible to the logged-in user.
Fix by calling d.SetUniq("linux-id") before Open(), matching the name
already shown in HID_NAME, so the uevent parses cleanly.
Fixes matejsmycka#31
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
Contributor
Author
|
Proof that this works, counterintuitive as the fix may be (this is with BeforeThe problem is that and https://demo.yubico.com/webauthn-technical/login hangs
AfterThe fix is that https://demo.yubico.com/webauthn-technical/login makes linux-id prompt and auth succeeds:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



psanford/uhid fills the uniq field with 64 random bytes when unset. Binary garbage in HID_UNIQ causes 90-brltty-hid.rules to abort the entire udev transaction for the hidraw device, so fido_id never runs, ID_SECURITY_TOKEN is never set, and uaccess is never granted — leaving /dev/hidraw* inaccessible to the logged-in user.
I'm confused about why this wasn't a problem before? Did psanford/uhid change something? Did systemd? Did Arch?
Digging this out was stupidly deep. Thanks to Claude for the heavy lifting.
Fixes #31