Skip to content

switch default filter type from quotient to bloom #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyastolfi merged 5 commits into from
Jun 23, 2026
Merged

switch default filter type from quotient to bloom #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4838e3
switch default filter type from quotient to bloom
tonyastolfi Jun 22, 2026
bcb2f74
Remove extra 'visible=True'
tonyastolfi Jun 22, 2026
861e5c7
Fix test package CMakeLists.txt.
tonyastolfi Jun 22, 2026
0d38a99
Set package_info.cxx_flags to reflect options.
tonyastolfi Jun 22, 2026
771e4cb
Upgrade to llfs/0.47.1.
tonyastolfi Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conan.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"libpfm4/4.13.0",
"libunwind/1.8.1",
"liburing/2.11",
"llfs/0.46.0",
"llfs/0.47.1",
"openssl/3.6.0",
"pcg-cpp/cci.20220409",
"protobuf/3.21.12",
Expand Down
19 changes: 16 additions & 3 deletions conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ class TurtleKvRecipe(ConanFile):

default_options = {
"with_keyvcr": False,
"use_bloom_filter": False,
"use_quotient_filter": True,
"use_bloom_filter": True,
"use_quotient_filter": False,
"enable_leaf_filters": True,
"enable_metrics": True,
"profile_updates": True,
Expand Down Expand Up @@ -92,7 +92,7 @@ def requirements(self):
self.requires("batteries/[>=0.71.1 <1]", **VISIBLE, **OVERRIDE)
self.requires("boost/1.88.0", **VISIBLE, **OVERRIDE)
self.requires("glog/0.7.1", **VISIBLE)
self.requires("llfs/[>=0.46.0 <1]", **VISIBLE)
self.requires("llfs/[>=0.47.0 <1]", **VISIBLE)
self.requires("pcg-cpp/cci.20220409", **VISIBLE)
self.requires("yaml-cpp/[>=0.9.0 <1]")
self.requires("zlib/1.3.1", **OVERRIDE)
Expand Down Expand Up @@ -144,6 +144,19 @@ def package(self):
def package_info(self):
self.cor.package_info_lib_default(self)

def _set_flags(name, value):
if value:
self.cpp_info.cxxflags += [f'-DTURTLE_KV_{name}=1']
else:
self.cpp_info.cxxflags += [f'-DTURTLE_KV_{name}=0']

_set_flags('USE_BLOOM_FILTER', self.options.use_bloom_filter)
_set_flags('USE_QUOTIENT_FILTER', self.options.use_quotient_filter)
_set_flags('ENABLE_LEAF_FILTERS', self.options.enable_leaf_filters)
_set_flags('ENABLE_METRICS', self.options.enable_metrics)
_set_flags('PROFILE_UPDATES', self.options.profile_updates)
_set_flags('PROFILE_QUERIES', self.options.profile_queries)

def package_id(self):
self.cor.package_id_lib_default(self)

Expand Down
2 changes: 1 addition & 1 deletion test_package/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ find_package(turtle_kv CONFIG REQUIRED)


add_executable(example src/example.cpp)
target_link_libraries(example turtle_kv::turtle_kv)
target_link_libraries(example batteries::batteries turtle_kv::turtle_kv)
2 changes: 1 addition & 1 deletion test_package/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class turtle_kvTestConan(ConanFile):

def requirements(self):
self.requires(self.tested_reference_str)
self.requires("batteries/[>=0.71.1 <1]", visible=True, force=True)
self.requires("batteries/[>=0.71.1 <1]", force=True)

def build(self):
cmake = CMake(self)
Expand Down