Skip to content

Split the UI to have list and add/edit as separate action, #PG-4995#16

Merged
AltamashShaikh merged 11 commits into5.x-devfrom
PG-4995-improve-ui
Apr 9, 2026
Merged

Split the UI to have list and add/edit as separate action, #PG-4995#16
AltamashShaikh merged 11 commits into5.x-devfrom
PG-4995-improve-ui

Conversation

@AltamashShaikh
Copy link
Copy Markdown
Contributor

Description

Split the UI to have list and add/edit as separate action

Issue No

#PG-4995

Steps to Replicate the Issue

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [✔] Are all newly added texts included via translation?
  • [✔] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

@AltamashShaikh AltamashShaikh added the Needs Review For pull requests that need a code review. label Apr 7, 2026
@AltamashShaikh AltamashShaikh requested a review from lachiebol April 7, 2026 08:12
lachiebol
lachiebol previously approved these changes Apr 7, 2026
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, gave UI a check and nothing obvious

Comment thread Activity/SetClientActive.php
@AltamashShaikh
Copy link
Copy Markdown
Contributor Author

@lachiebol Applied feedbacks from Stan

@AltamashShaikh AltamashShaikh requested a review from lachiebol April 8, 2026 04:33
lachiebol
lachiebol previously approved these changes Apr 9, 2026
@AltamashShaikh AltamashShaikh requested a review from lachiebol April 9, 2026 02:38
@AltamashShaikh AltamashShaikh merged commit fd8cbab into 5.x-dev Apr 9, 2026
8 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-4995-improve-ui branch April 9, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants