Include spec release in filenames in built tarball #2276
+24
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's slightly confusing that everything just ends up under `spec/`, so let's put the version number in there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it slightly confusing that the tarballs generated by CI just have everything under
spec/, rather than including the version number.This PR changes things so that the paths in the tarball mirror the URLs contained within the spec. In other words:
vNNtag will contain the generated spec under/vNN/.mainbranch will contain the generated spec under/unstable/.If we merge this, we will need to followup with a change to the autodeployer for https://spec.matrix.org/unstable, so that it knows to find the generated spec at
/unstablerather than/spec.