fix: keyboard shortcut added for #3#5
Conversation
|
Thanks for picking this up — the overall approach is solid, and a couple Two things I'd like fixed before merging:
Minor nit — title has a typo, "shortcute" → "shortcut". Worth fixing in Looks good overall, let me know when those are done and I'll merge. |
|
All requested fixes are done: package-lock.json reverted, paramsChanged now includes sprueOverrideChanged via useMemo, and commit message typo fixed. Ready for merge. Please check and let me know thanks. |
|
resolved the conflicts, please check |
|
Thanks for the conflict resolution — unfortunately the rebase against main introduced a few new issues that need to be cleaned up before this can land. The good news is the fixes are small and localized. Three blockers, in order of importance:
Minor cleanups while you're in there:
The keyboard-handling logic itself (text-input vs slider distinction, the no-op-when-up-to-date check) is good and exactly what I wanted. It's just the rebase that needs another pass. Let me know when those three are sorted and I'll get this merged. Generated by Claude Code |
Adds Ctrl+Enter / Cmd+Enter as a keyboard shortcut for the Generate Mold action.
Hooks the global keydown listener in App.tsx
Triggers the same handleGenerate() path used by the Generate button
Works when focus is in sliders, buttons, or the 3D viewport
Does not fire when focus is inside text/number inputs or content-editable fields
No-op when no model is loaded or when the current mold is already up to date
This keeps the change focused on the keyboard shortcut only, with no visible UI hint added.