Skip to content

Document DCR redirect URI allowlist wildcard and query matching behavior#9065

Merged
esethna merged 2 commits into
v11.9-documentationfrom
MM-69392-dcr-uri-fix
Jul 9, 2026
Merged

Document DCR redirect URI allowlist wildcard and query matching behavior#9065
esethna merged 2 commits into
v11.9-documentationfrom
MM-69392-dcr-uri-fix

Conversation

@pvev

@pvev pvev commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Documents the OAuth Dynamic Client Registration (DCR) redirect URI allowlist matching behavior the * and ** wildcards, per-URL-component matching, and the rule that query strings match only when a pattern explicitly includes one — so admins know how to write patterns and how to allow query-bearing redirect URIs.

Ticket Link

https://mattermost.atlassian.net/browse/MM-69392

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5bf185e-37e7-4559-86c5-84fcfa6505d1

📥 Commits

Reviewing files that changed from the base of the PR and between 2b08f6f and 0246b8c.

📒 Files selected for processing (1)
  • source/administration-guide/configure/integrations-configuration-settings.rst

📝 Walkthrough

Walkthrough

Nine lines of documentation are added to integrations-configuration-settings.rst under the DCR redirect URI allowlist section, describing how URI matching works: per-component matching, wildcard semantics (* vs **), restrictions on cross-component wildcard use, and query string matching requirements.

Changes

DCR Redirect URI Allowlist Documentation

Layer / File(s) Summary
Redirect URI matching rules
source/administration-guide/configure/integrations-configuration-settings.rst
Adds documentation specifying per-URL-component matching, wildcard semantics (* matches anything except /, ** includes /), component-local wildcard constraints, and query string matching behaviour including guidance for permitting both query and non-query redirect URIs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main documentation change about DCR redirect URI allowlist wildcard and query matching behaviour.
Description check ✅ Passed The description matches the documented DCR redirect URI allowlist matching behaviour and is clearly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MM-69392-dcr-uri-fix

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 0246b8c

@edgarbellot
edgarbellot self-requested a review June 26, 2026 13:54
@esethna
esethna changed the base branch from master to v11.9-documentation July 9, 2026 15:07
@esethna
esethna merged commit f9c50fe into v11.9-documentation Jul 9, 2026
5 checks passed
@esethna
esethna deleted the MM-69392-dcr-uri-fix branch July 9, 2026 15:07
@esethna esethna added this to the v11.9.0 milestone Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA 7f34d23

amyblais added a commit that referenced this pull request Jul 16, 2026
* Update conf.py

* MM-68992 - add attribute value masking documentation (#9000)

* MM-68992 - add attribute value masking documentation

* add details about access mode

* Document experimental video calls in DMs (Calls v1.12.0) (#9050)

* Document experimental video calls in DMs (Calls v1.12.0)

* Note external RTCD v1.2.2+ requirement for DM video calls

* MM-69311: Document new metric: mattermost_cluster_reliable_fallback_tcp (#9068)

* Document mattermost_cluster_reliable_fallback_tcp

* Update source/administration-guide/scale/performance-monitoring-metrics.rst

Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com>

---------

Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com>

* Document DCR redirect URI allowlist wildcard and query matching behavior (#9065)

Co-authored-by: Eric Sethna <14333569+esethna@users.noreply.github.com>

* Document the Ranked attribute type (#9086)

Add a Ranked entry to the user-attribute type list, document its ordered
comparison operators in the system-wide access policy match options, and
note that classification markings use the same Ranked attribute type.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

* v11.9.0 Changelog (#9053)

* docs: add changelog for v11.9.0

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update source/product-overview/mattermost-v11-changelog.md

Co-authored-by: Christopher Poile <cpoile@gmail.com>

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Add 3 bug fix release notes to v11.9.0 changelog

* Update source/product-overview/mattermost-v11-changelog.md

Co-authored-by: Christopher Poile <cpoile@gmail.com>

* Update mattermost-v11-changelog.md

* Add Jira plugin v4.7.1 release note to v11.9.0 changelog

* Fix: use Pre-packaged for Jira plugin v4.7.1 release note

* Add attribute value masking information to 11.8.0 changelog docs (#9076)

* Add attribute value masking information to 11.8.0 changelog docs

* move changes under v11.9 section

* Add inline link for attribute value masking in v11.9 changelog

* Update Agents plugin version from v2.4.1 to v2.4.2 in v11.9 changelog

* Add Global Relay crash fix to v11.9 Bug Fixes section

* Add Global Relay fix to v11.9 Bug Fixes with correct wording

* Add inline link for metric on line 106

* Update v11.9 changelog: bug fix, feature flag note, Calls v1.12.1

* Fix formatting: backticks for feature flags, bold for Channel Settings Permissions Policy

* Update source/product-overview/mattermost-v11-changelog.md

Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>

* Update v11.9 changelog: replace feature flag line 110 with ChannelPermissionPolicies/PolicySimulation description

* Add PropertyGroups and channelbookmarks schema changes to v11.9 changelog

* Update mattermost-v11-changelog.md

* Add ChannelGuards schema change to v11.9 changelog

* Add stale config refresh fix to v11.9 changelog

* Update mattermost-v11-changelog.md

* Add Bot Accounts pagination fix to v11.9 changelog

* Remove duplicate Boards plugin version line

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

* Update mattermost-v11-changelog.md

---------

Co-authored-by: Changelog Bot <changelog-bot@mattermost.com>
Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com>
Co-authored-by: Christopher Poile <cpoile@gmail.com>
Co-authored-by: Pablo Vélez <pablovv2012@gmail.com>
Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>

* Update version-archive.rst (#9092)

* v11.9 release docs (#9058)

* Add v11.9 release docs scaffolding

Mechanical version scaffolding for the v11.9 (2026-07-16) feature release:
- Add v11.9 row to the server Latest releases table
- Bump latest-release download to 11.9.0 in deploy-rhel and deploy-tar
- Add v11.9.0 server entry to open source components
- Add v11.9 to the Desktop App v6.2 "Compatible with" list

Co-authored-by: Amy Blais <amyblais@users.noreply.github.com>

* Update open-source-components.rst

* Update ui-ada-changelog.rst

* Update release-policy.md

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* Update ui-ada-changelog.rst

* Update important-upgrade-notes.rst

* Update ui-ada-changelog.rst

* Resolve conflict in deploy-rhel.rst

* Resolve conflict in deploy-tar.rst

* Resolve conflict in mattermost-server-releases.md

* Update important-upgrade-notes.rst

* Update important-upgrade-notes.rst

* MM-69392 - DCR changes upgrade notes (#9089)

---------

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Amy Blais <amyblais@users.noreply.github.com>

---------

Co-authored-by: Pablo Vélez <pablovv2012@gmail.com>
Co-authored-by: Bill Gardner <billg@wavearts.com>
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
Co-authored-by: Eric Sethna <14333569+esethna@users.noreply.github.com>
Co-authored-by: David Krauser <david@krauser.org>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: changelog-automation-docs[bot] <278388344+changelog-automation-docs[bot]@users.noreply.github.com>
Co-authored-by: Changelog Bot <changelog-bot@mattermost.com>
Co-authored-by: Christopher Poile <cpoile@gmail.com>
Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Amy Blais <amyblais@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants