Prevent colon confusion in output parsing#32
Open
unDeadHerbs wants to merge 1 commit intomattijn:masterfrom
Open
Prevent colon confusion in output parsing#32unDeadHerbs wants to merge 1 commit intomattijn:masterfrom
unDeadHerbs wants to merge 1 commit intomattijn:masterfrom
Conversation
unDeadHerbs
force-pushed
the
patch-1
branch
2 times, most recently
from
474946a to
9243556
Compare
By use a magic string that shouldn't appear in code, we make parsing easier. Really we should use a parser or something; but, this is an easy enough fix. Fixes mattijn#20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using a magic string that shouldn't appear in code, we make "parsing" easier. Really this should use a real parser call into the library; but, this is an easy enough fix.
Fixes #20