Vertically block move: fit to relative line count (fixes #79) #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think it should be made an opt-in feature because a) it is pretty breaking behaviour and b) at least I don't use relative line numbers. |
awvalenti
force-pushed
the
master
branch
4 times, most recently
from
f9a4bca to
9c93997
Compare
Contributor
Author
|
OK, it's opt-in now. I renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this PR to change vertical block movement. Old behavior: count means "total distance of the movement". New behavior: count means "destination position of block, relative to cursor". See #79.
I made a few experiments and I believe this could become the new default behavior, without requiring configuration. I don't see much usefulness in thinking in terms of distance instead of destination. This is because many (most?) Vim users use relative line numbers all the time. In case you disagree and prefer this to be an opt-in feature, I can add a config for it.