bridgev2/userlogin: copy the remote profile when filling bridge state

[slice]

Here's the relevant line:

go/bridgev2/userlogin.go

Line 515 in 7836f35

state.RemoteProfile = &ul.RemoteProfile

By pointing into ul.RemoteProfile directly, the "pending" BridgeState will always point to the "latest" RemoteProfile, which leads the RemoteProfile comparison in ShouldDeduplicate to always think that the RemoteProfile hasn't changed:

go/bridgev2/status/bridgestate.go

Lines 208 to 213 in 7836f35

	func (pong *BridgeState) ShouldDeduplicate(newPong *BridgeState) bool {
	return pong != nil &&
	pong.StateEvent == newPong.StateEvent &&
	pong.RemoteName == newPong.RemoteName &&
	pong.UserAction == newPong.UserAction &&
	ptr.Val(pong.RemoteProfile) == ptr.Val(newPong.RemoteProfile) &&

I think it's always going to dereference the same two pointers; i.e. it does *ul.RemoteProfile == *ul.RemoteProfile which would always be true.

We can make a copy instead, which will do a shallow snapshot of sorts:

	profileCopy := ul.RemoteProfile
	state.RemoteProfile = &profileCopy

It wouldn't be resilient to in-place AvatarFile mutations that don't take care to replace the entire value, but that seems okay?

[tulir]

Might be better to just make BridgeState.RemoteProfile a non-pointer