connector,messagix: support backfill of all chats #196
+158
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fizzadar
force-pushed
the
nick/backfill-all-chats
branch
3 times, most recently
from
ec685e6 to
8d27f18
Compare
Fizzadar
force-pushed
the
nick/backfill-all-chats
branch
from
8d27f18 to
b7a3511
Compare
Chats only, no messages. Though in testing it appears to pick up the most recent messages for each room as we paginate anyway.
Fizzadar
force-pushed
the
nick/backfill-all-chats
branch
from
b7a3511 to
90b6f3c
Compare
tulir
reviewed
Jan 19, 2026
pkg/connector/example-config.yaml
Outdated
| # Thread backfill settings for syncing older conversations | ||
| thread_backfill: | ||
| # Enable thread list backfill to sync older conversations on connect | ||
| enabled: false |
Member
There was a problem hiding this comment.
Batch count limit would probably be more appropriate than an enabled boolean (-1 for unlimited, 0 for disabled, >0 for limited)
pkg/connector/threadbackfill.go
Outdated
|
|
||
| batchCount++ | ||
|
|
||
| keyStore := m.Client.GetSyncGroupKeyStore(1) |
Member
There was a problem hiding this comment.
Fetching this inside FetchMoreThreads and again here is a bit weird
Member
Author
There was a problem hiding this comment.
Yeah should just come back from fetch more => 4281417
Fizzadar
changed the title
tulir
reviewed
Jan 19, 2026
| helper.Copy(up.Bool, "send_presence_on_typing") | ||
| helper.Copy(up.Bool, "receive_instagram_typing_indicators") | ||
| helper.Copy(up.Bool, "disable_view_once") | ||
| helper.Copy(up.Bool, "thread_backfill", "enabled") |
Member
There was a problem hiding this comment.
Suggested change
| helper.Copy(up.Bool, "thread_backfill", "enabled") | |
| helper.Copy(up.Int, "thread_backfill", "batch_count") |
| helper.Copy(up.Bool, "receive_instagram_typing_indicators") | ||
| helper.Copy(up.Bool, "disable_view_once") | ||
| helper.Copy(up.Bool, "thread_backfill", "enabled") | ||
| helper.Copy(up.Str, "thread_backfill", "batch_delay") |
Member
There was a problem hiding this comment.
I think duration parsing allows numbers too (mostly useful for 0)
Suggested change
| helper.Copy(up.Str, "thread_backfill", "batch_delay") | |
| helper.Copy(up.Str|up.Int, "thread_backfill", "batch_delay") |
| delay := m.Main.Config.ThreadBackfill.BatchDelay | ||
|
|
||
| batchCount := 0 | ||
| lastMinThreadKey := m.Client.GetSyncGroupKeyStore(1).MinThreadKey |
Member
There was a problem hiding this comment.
Can the key store be nil? (i.e. will this panic?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chats, not messages.