fix(skill): strengthen details-tag and local-test-verification guidance#1447
fix(skill): strengthen details-tag and local-test-verification guidance#1447
Conversation
…ance Two recurring issues found in hourly review of runs from the past hour: 1. Long comments posted without <details> tags (3 sessions). The existing guidance was too vague — "file-by-file breakdowns, code snippets" didn't cover technical analyses with headers, tables, and surveys. Added a concrete threshold (~15 lines, multiple headers/tables) and explicit examples. 2. Local test failures characterized as "pre-existing" without verification (run 22967660638). This is the 3rd recurrence of the pattern from #1335 and #1384. The grounded-analysis guidance exists but isn't encountered at the decision point (local tests before pushing). Added an inline reminder in the CI Monitoring section with the verification command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
…ance Soften the <details> tag rule: add a "when NOT to use" section clarifying that long replies are fine when the content is the primary answer (e.g., a requested survey), not just supporting detail around a short conclusion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Good call on #1 — those were direct answers to questions, not boilerplate around a short conclusion. I've added a "when NOT to use Pushed in b7adfa8. |
|
just make one cohesive paragraph of when to use details tags |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Consolidated into a single paragraph — use |
Summary
Two recurring behavioral issues found in hourly review of 14 Claude CI runs (12 successful, 2 cancelled) from the past hour:
1. Long comments posted without
<details>tags (3 sessions)The
running-in-ciskill says to use collapsible sections for detailed analysis, but the guidance was too vague — it only mentioned "file-by-file breakdowns, code snippets." The bot consistently posts multi-section technical analyses (headers, tables, surveys) without collapsing them.Evidence:
Fix: Added a concrete threshold (~15 lines, multiple headers/tables) and made clear that technical analyses always need collapsible sections.
2. Local test failures characterized as "pre-existing" without verification (3rd recurrence)
This is a recurrence of #1335 and #1384. The grounded-analysis guidance exists at lines 316-320 of the skill, but the bot doesn't apply it when running local tests before pushing — only when monitoring CI after pushing.
Evidence:
cargo test, saw 61 failures inci_statusandswitch_prtest categories, and said "These look like CI-related test failures which are likely pre-existing or environment-dependent" — without runninggh apito verify main branch CI. The bot then pushed and created the PR anyway.Fix: Added an explicit "Verifying local test failures before pushing" subsection in the CI Monitoring section, placed right at the decision point where this pattern occurs.
Other sessions reviewed (no issues found)
Positive patterns: Shell quoting was correct across all 12 sessions (temp files with single-quoted heredocs). Self-authored PR handling was correct (silent, no self-approval). Review thread replies used the correct API endpoint.
Test plan
<details>tag usage🤖 Generated with Claude Code