Skip to content

Remove legacy Extra Large handling from font size selection #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxistar merged 1 commit into from
Nov 27, 2025
Merged

Remove legacy Extra Large handling from font size selection #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/main/java/com/maxistar/textpad/activities/EditorActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,9 @@ private void applyFontSize() {
case (SettingsService.SETTING_HUGE):
mText.setTextSize(28.0f);
break;
case (SettingsService.SETTING_EXTRA_HUGE):
mText.setTextSize(56.0f);
break;
case (SettingsService.SETTING_MEDIUM):
default:
mText.setTextSize(20.0f);
Expand Down
17 changes: 14 additions & 3 deletions app/src/main/java/com/maxistar/textpad/preferences/FontSizePreference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ public FontSizePreference(Context context, AttributeSet attrs) {
break;
case SettingsService.SETTING_HUGE:
selected = 4;
break;
case SettingsService.SETTING_EXTRA_HUGE:
selected = 5;
break;
}
}

Expand All @@ -72,10 +76,13 @@ public void onClick(DialogInterface dialog, int whichButton) {
case 3:
settingsService.setFontSize(SettingsService.SETTING_LARGE, getContext());
break;
case 4:
case 4:
settingsService.setFontSize(SettingsService.SETTING_HUGE, getContext());
break;
}
case 5:
settingsService.setFontSize(SettingsService.SETTING_EXTRA_HUGE, getContext());
break;
}

notifyChanged();
}
Expand All @@ -88,7 +95,8 @@ public void onClick(DialogInterface dialog, int whichButton) {
SettingsService.SETTING_SMALL,
SettingsService.SETTING_MEDIUM,
SettingsService.SETTING_LARGE,
SettingsService.SETTING_HUGE
SettingsService.SETTING_HUGE,
SettingsService.SETTING_EXTRA_HUGE
};

List<String> fonts = Arrays.asList(arrayOfFonts);
Expand Down Expand Up @@ -143,6 +151,9 @@ public View getView(int position, View convertView, @NonNull ViewGroup parent)
break;
case SettingsService.SETTING_HUGE:
tv.setTextSize(28.0f);
break;
case SettingsService.SETTING_EXTRA_HUGE:
tv.setTextSize(56.0f);
}
// general options
tv.setTextColor(Color.BLACK);
Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/com/maxistar/textpad/service/SettingsService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public class SettingsService {
public static final String SETTING_SMALL = "Small";
public static final String SETTING_LARGE = "Large";
public static final String SETTING_HUGE = "Huge";
public static final String SETTING_EXTRA_HUGE = "Extra Huge";

public static final int DEFAULT_BACKGROUND_COLOR = 0xFFDDDDDD;
public static final int DEFAULT_TEXT_COLOR = 0xFF000000;
Expand Down