Skip to content

Fixed icon color in menu #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krishnapandey24 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed icon color in menu #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/res/menu/main_menu.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
android:id="@+id/menu_document_search"
android:title="@string/Search"
android:icon="@drawable/ic_search"
app:iconTint="@color/colorIcon"
app:iconTint="@color/menuIconColor"
app:actionViewClass="android.widget.SearchView"
app:showAsAction="ifRoom|collapseActionView" />
<item
android:id="@+id/action_edit"
android:title="@string/action_edit"
android:icon="@drawable/ic_edit"
app:iconTint="@color/colorIcon"
app:iconTint="@color/menuIconColor"
app:showAsAction="ifRoom">
<menu>
<item
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/colors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
<color name="colorPrimaryDark">#303F9F</color>
<color name="colorAccent">#404081</color>
<color name="colorIcon">#7F7F7F</color>
<color name="menuIconColor">#fff</color>
Copy link
Owner

@maxistar maxistar Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I made it grey if there is not enough space for the search and edit icon the icon will appear in the options menu and it is going to be invisible because it will be white on white background. I think in android should be another solution for this problem but I do not exactly know which one.

Copy link
Author

@krishnapandey24 krishnapandey24 Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grey icons don't look good at all. Also, there is always going to me enough space for those two icons even in smaller screen size.

</resources>