Misc cleanup #185
Merged
Misc cleanup #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Jan 29, 2025
oschwald
commented
- Run latest black version on code
- Add basic ruff config
- Run ruff's auto-fixer
- Apply unsafe fixes from ruff
- Add missing types
oschwald
force-pushed
the
greg/eng-1164
branch
from
75b0022 to
f119692
Compare
horgh
requested changes
Jan 29, 2025
oschwald
force-pushed
the
greg/eng-1164
branch
3 times, most recently
from
7952cd4 to
32c86ed
Compare
oschwald
force-pushed
the
greg/eng-1164
branch
from
32c86ed to
4c9eb57
Compare
horgh
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.