Improve simulator#172
Open
xnoreq wants to merge 5 commits into
Open
Conversation
instead of counting hits, keep track of distances to next accesses (`next`) and use a max-heap to evict the item with the highest distance
xnoreq
force-pushed
the
improve-simulator
branch
from
8fdb879 to
f5bd253
Compare
xnoreq
force-pushed
the
improve-simulator
branch
from
f5bd253 to
f128db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While going through benchmarks I noticed that simulator was using outdated modules.
Furthermore, there was an "optimal" policy, but it was neither enabled nor implemented correctly.
This PR fixes all these issues.
Related issue(s)
None
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Public contracts
Stylistic guide (mandatory)
Before merging (mandatory)
TODO: