Version keys read from build settings, not hardcoded plist strings - #27
Merged
Conversation
The archive kept stamping 10.0 despite the MARKETING_VERSION bump: the app target uses an explicit Info.plist (GENERATE_INFOPLIST_FILE = NO) whose CFBundleShortVersionString hardcoded "10.0", overriding the build setting entirely. The plist now references $(MARKETING_VERSION) / $(CURRENT_PROJECT_VERSION) so the pbxproj is the single source of truth for versioning - verified the built product stamps 10.1 (3). Organizer's build renumbering during upload continues to work as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the archive still showing 10.0 after PR #26: the explicit
Info.plisthardcodedCFBundleShortVersionString = 10.0, which overridesMARKETING_VERSIONentirely. The plist now references$(MARKETING_VERSION)/$(CURRENT_PROJECT_VERSION)so the project file is the single source of truth. Verified the built product stamps 10.1 (3).🤖 Generated with Claude Code