forked from ComputeCanada/magic_castle
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade archimedes-2 to latest Magic Castle #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves the ability to explictly specify the A records, but by default all traffic that falls in the wild card will now be directed to reverse proxy.
Replace list of specific subdomains by *
Otherwise, puppet risks erroring when applying the catalog with this message: Failed to apply catalog: Parameter key failed on Ssh_authorized_key[centos_0]: Key must not contain whitespace:
Make sure ssh keys do not have whitespace prefix or suffix
Limit the choices to only what is possible given the selected instance types instead of all AZ available.
…mprov Reduce choices of availablity zones in AWS
Also define a map for minimum disk per tags that used in conjunction with the minimum root disk size is used to specify the disk size of each instance in the design module.
Improve instance root disk size computation and warnings
Add Trivy misconfiguration scan of Terraform code
It is deprecated and we used it only a small number of files
Modernize github workflows
…prefix Make count optional in validation
Add advanced examples to validation in CI/CD
It is optional and has no use in Magic Castle as we supply our own cloud-init.
Remove key pair resource in AWS
…eport Enable puppet prometheus reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.