fix: Better error handling in shapes_from_kml - #1414
Open
zyxw59 wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Was it @dks-mbta who had the bad shapefile that triggered this? |
lemald
reviewed
Jul 28, 2026
Comment on lines
+89
to
+92
| _ -> | ||
| {:error, | ||
| {"Failed to parse shape from kml, placemarks are of unexpected type.", | ||
| [inspect(placemarks)]}} |
Member
There was a problem hiding this comment.
suggestion: we should probably add a unit test for this (or is that what you're asking for the example malformed KML for?).
lemald
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: extra
Adds additional validation/handling in
shapes_from_kmlthat will return an error on a malformed file rather than crashing.Sentry link: https://mbtace.sentry.io/issues/7636773354/?referrer=slack¬ification_uuid=3a35208d-6121-48d9-b978-142cd216356e&environment=prod&alert_rule_id=13911605&alert_type=issue
Reviewer Checklist