feat(ScheduleFinderLive): school days only badge #2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was already int here, let's just parse it earlier
thecristen
force-pushed
the
cbj/sf2.0/school-trips
branch
from
2e842b9 to
c372936
Compare
Collaborator
Author
|
Updating to move the badge to after the headsign: 
|
joshlarson
requested changes
Jan 8, 2026
Contributor
joshlarson
left a comment
joshlarson
left a comment
There was a problem hiding this comment.
Requesting changes because I think we actually should have a test that shows where the time_desc field comes from.
| ] | ||
| } | ||
| }) do | ||
| defp to_departure(%Schedule{schedule_id: schedule_id, route: route, trip: trip} = schedule) do |
Contributor
There was a problem hiding this comment.
Style question: How come you pattern-matched some fields, but are getting the rest as (for instance) schedule.stop_headsign?
Collaborator
Author
There was a problem hiding this comment.
I can't claim it's a smart reason, but I didn't want the formatter to break this up into multiple lines 🫠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs approval but here it is!
Previews from
/preview/schedules/39/0?stop=1365