Persistent Favorited Stops

[TheStaticBits]

Added a variable to track favorited stop markers (_displayedFavoriteStopMarkers) for persistent-displayed favorited stops. This is then updated alongside stop markers or whenever the user favorites/unfavorites a bus stop. also -- I have not tested this on iOS as I do not have an iPhone.

Potential concern: it looks like stops where multiple busses stop have a marker for each bus route (such as the CCTC Chemistry stop, which has 8 markers), and this system currently favorites all of them and has them all persistently display when the stop is favorited, which could be a performance concern.

[i-kumar]

looks good - works on iOS

[iswheeler]

hey Matthew, thanks for your hard work on this!

Noticed a couple bugs (not sure if they're from your changes or existed before); could you take a look at these please?

• When you favorite some stops, they lose their direction (in the video you can see that the stop I clicked on goes from pointing right to pointing straight down)
• When you favorite a TheRide stop and unfavorite it, MaizeBus shows a blue campus bus icon instead of a red TheRide icon (see video)

maizebus_matthew_feature.mp4

Also, about the duplicate stops consideration--if you wanted to try to tackle that problem, you might have luck changing _displayedStopMarkers and _displayedFavoriteStopMarkers to a Map<String, Marker> instead of a Set--that way, you could have the bus stop number (i.e. "C250") map to a Marker. So if you have e.g. 8 routes enabled, the code runs _displayedStopMarkers["C250"] = Marker(...) 8 times but only the last Marker ends up stored in _displayedStopMarkers. If you need to pass a Set to the Google Maps widget, there's a _displayedStopMarkers.value.toSet() function that should work

[iswheeler]

Whoops, just found the button to request changes. See the post above in the conversation for feedback :)

[i-kumar]

good catch. im so glad we have the pr system

[TheStaticBits]

• I have added a Map variable tracking which stops are The Ride (_isStopRide), fixing the bug where theRide bus stops turn blue after unfavoriting them.
• I have also fixed duplicate bus stop markers per stop by turning _displayedStopMarkers and _displayedFavoriteStopMarkers into Maps mapping stop_id to markers, as an optimization.
• I can't seem to reproduce the bug where favorited stops lose their rotation, I have tried running it on my physical Pixel 8a and also my Pixel 9 emulator on Windows @iswheeler

[iswheeler]

Looks good!
I did notice one more tiny bug--looks like the stop favorite status doesn't load until the rest of the bus stop info has been downloaded. I deliberately slowed down the network of my emulator--note that the heart button only gets filled in once the buses load.

Could you look into seeing if there's a way to load the favorite status as soon as the sheet opens? If not I don't think it's a huge issue, but I imagine this would (hopefully) be a small change

maizebus_apr_3_3.mov