perf(search): Cache building list at startup to speed up search#82
Open
SiddhantBhirud wants to merge 2 commits intomaizebus-2.1from
Conversation
…very search Previously the building list was fetched from the backend every time the search button was tapped. Moved the fetch to app startup and stored it in a global variable, reusing it in the search sheet to make search instant.
SiddhantBhirud
changed the title
SiddhantBhirud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the building list was fetched from the backend every time the search button was tapped. Now it is cached at startup in a global variable and reused in the search sheet, making search snappy.
Type of Change
feat)fix)Changes Made
globalBuildingLocstoglobals.dartto cache buildings in memory_loadStopsForLaunchinmap_screen.dartto fetch buildings at startupsearch_sheet_main.dartto use cached data instead of fetching on every searchTesting Done
Flutter:
Checklist
[type](scope): short descriptionmainand is our current working update branchprint()/debugPrint()/console.log()left in production code