Skip to content

Conversation

@Lomholy
Copy link
Collaborator

@Lomholy Lomholy commented Aug 25, 2025

Previously my_s would contain both my_inc and my_s_v2_sum, which seems to be an inclusion of all the other possible scattering processes in a sorta mimicking multiple scattering way.

This however is not in accordance with how the analytical calculations are derived, and this change allows a user to recreate the results one would expect from single scattering.

@willend
Copy link
Contributor

willend commented Aug 26, 2025

@Lomholy thank you for the PR, which I hereby accept and will merge. I attach a the output of a little testing done via my local installation (copied the modified comp to $MCSTAS/samples and ran the mctest / mcviewtest tools) :

mctest --instr=PSI_DMC --testdir=$PWD --mpi=auto -n5e7
mctest --instr=ISIS_GEM --testdir=$PWD --mpi=auto -n5e7
mctest --instr=Test_Powder --testdir=$PWD --mpi=auto -n5e7
mcviewtest $PWD
Screenshot 2025-08-26 at 11 56 39

@willend willend merged commit dcc1c40 into main Aug 26, 2025
44 checks passed
@Lomholy Lomholy deleted the PowderN_Validation branch November 25, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants