Skip to content

Update pyproject and uv lock to fix missing typing_extensions dependency #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitrhmn1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pyproject and uv lock to fix missing typing_extensions dependency #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ classifiers = [
"Programming Language :: Python :: 3.13",
"Topic :: Software Development :: Libraries",
]
dependencies = [
"typing-extensions",
Copy link

@merwok merwok Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is very often conditional (on python version), to make use of features that are backported from the typing module in the most recent python version. Is this the case for this project?

Copy link
Author

@rohitrhmn1 rohitrhmn1 Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, in the latest versions of python-ulid, this package is imported somewhere and is not mentioned in the dependencies. Adding this in the package will solve the import issues.

For the sake of features that are backported, this project can mark minimum python version and use features for the recently available versions of python. Removing certain usages of this package inside the project will fix the problem.

]

[project.urls]
Homepage = "https://github.com/mdomke/python-ulid"
Expand Down
10 changes: 8 additions & 2 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.