Add optional HTTP origin parameter to Session.#43
Open
nosmo wants to merge 1 commit intomediawiki-utilities:masterfrom
Open
Add optional HTTP origin parameter to Session.#43nosmo wants to merge 1 commit intomediawiki-utilities:masterfrom
nosmo wants to merge 1 commit intomediawiki-utilities:masterfrom
Conversation
Interally within WMF we do not access the API servers via external hostnames, but we need to access the APIs for a given wiki via our internal appserver endpoint. Currently this is not possible as using the appserver hostname directly doesn't set a valid Host header for a wiki. This change adds an `origin` parameter to the Session object which allows the host to be used as the HTTP Host header while connecting to the IP or hostname of the given `origin`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interally within WMF we do not access the API servers via external
hostnames, but we need to access the APIs for a given wiki via our
internal appserver endpoint. Currently this is not possible as using
the appserver hostname directly doesn't set a valid Host header for a
wiki. This change adds an
originparameter to the Session objectwhich allows the host to be used as the HTTP Host header while
connecting to the IP or hostname of the given
origin.